Skip to content

Add mass and findBestNOccurrences functions#52

Merged
jrecuerda merged 1 commit intomasterfrom
feature/findBestNOccurrences
Jun 6, 2019
Merged

Add mass and findBestNOccurrences functions#52
jrecuerda merged 1 commit intomasterfrom
feature/findBestNOccurrences

Conversation

@jrecuerda
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

Comment thread khiva/matrix.py Outdated
:param time_series: Array whose first dimension is the length of the time series and the second dimension is the
number of time series.
:param number_of_occurrences: Number of matches to return.
:return: KHIVA arrays with the distances and indexes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot missing at the end of line.

Comment thread khiva/matrix.py Outdated
dimension is the number of queries.
:param time_series: Array whose first dimension is the length of the time series and the second dimension is the
number of time series.
:return: KHIVA array with the distances
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem.

@jrecuerda jrecuerda force-pushed the feature/findBestNOccurrences branch from 0a1135f to 5f3d50f Compare June 5, 2019 14:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2019

Codecov Report

Merging #52 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #52     +/-   ##
=========================================
+ Coverage   94.23%   94.63%   +0.4%     
=========================================
  Files          14       14             
  Lines         867      876      +9     
=========================================
+ Hits          817      829     +12     
+ Misses         50       47      -3
Flag Coverage Δ
#Linux 93.37% <100%> (?)
#MacOS 93.15% <100%> (?)
#Windows 94.29% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
khiva/array.py 88.1% <ø> (ø) ⬆️
khiva/matrix.py 100% <100%> (ø) ⬆️
khiva/library.py 91.8% <0%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd0204...bfc184c. Read the comment docs.

Copy link
Copy Markdown
Contributor

@avilchess avilchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@jrecuerda jrecuerda force-pushed the feature/findBestNOccurrences branch 2 times, most recently from a0ad7f5 to 20c178f Compare June 6, 2019 06:41
@jrecuerda jrecuerda force-pushed the feature/findBestNOccurrences branch from 20c178f to bfc184c Compare June 6, 2019 07:12
@jrecuerda jrecuerda merged commit bb3cb06 into master Jun 6, 2019
@jrecuerda jrecuerda deleted the feature/findBestNOccurrences branch June 6, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants